[webkit-reviews] review granted: [Bug 38846] Merge some pseudo-valid-*.html tests into one : [Attachment 55556] Patch

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 38846: Merge some pseudo-valid-*.html tests into one
https://bugs.webkit.org/show_bug.cgi?id=38846

Attachment 55556: Patch
https://bugs.webkit.org/attachment.cgi?id=55556&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
> +var notValidColor = "rgb(0, 255, 0)";
> +for (var i = 0; i < names.length; i++)
> +    shouldBe("getBackgroundColor('" + names[i] + "')", "notValidColor");

I slightly prefer rgb(0, 255, 0) to notValidColor because "foobar is not valid
color" sounds like this test is failing.

    shouldBe("getBackgroundColor('" + names[i] + "')", "rgb(0, 255, 0)");

Also, I think the color should be not valid nor invalid, right?