[webkit-reviews] review denied: [Bug 36335] Hashchange event is no longer a simple event, needs to be its own interface : [Attachment 55643] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 10 22:33:52 PDT 2010


Brady Eidson <beidson at apple.com> has denied Steven Lai <s3lance at hotmail.com>'s
request for review:
Bug 36335: Hashchange event is no longer a simple event, needs to be its own
interface
https://bugs.webkit.org/show_bug.cgi?id=36335

Attachment 55643: Patch
https://bugs.webkit.org/attachment.cgi?id=55643&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
Looks fine in code, but can't land without fixing the build breakage failures
for other platforms.

I'm wondering if maybe they need the JSHashChangeEvent.cpp added to their
build?	(I didn't actually look at the Qt failure that the bots caught)


More information about the webkit-reviews mailing list