[webkit-reviews] review granted: [Bug 38871] REGRESSION: Crash clicking background NPR tab after few minutes of sitting idle : [Attachment 55608] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 10 21:34:10 PDT 2010


Eric Carlson <eric.carlson at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 38871: REGRESSION: Crash clicking background NPR tab after few minutes of
sitting idle
https://bugs.webkit.org/show_bug.cgi?id=38871

Attachment 55608: Patch
https://bugs.webkit.org/attachment.cgi?id=55608&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> @@ -526,7 +547,7 @@ void HTMLMediaElement::loadInternal()
>      // If we can't start a load right away, start it later.
>      Page* page = document()->page();
>      if (page && !page->canStartMedia()) {
> -	   if (m_isWaitingUntilMediaCanStart)
> +	   if (m_isWaitingUntilMediaCanStart || !attached())
>	       return;

Are you certain this will work with audio elements created with "new Audio()"
(these elements are not in the DOM are playable)?

r=me if you have verified that this continues to work.


More information about the webkit-reviews mailing list