[webkit-reviews] review granted: [Bug 38862] svn-apply: Eliminate the "copiedFiles" hash : [Attachment 55638] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 10 19:06:28 PDT 2010
Eric Seidel <eric at webkit.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 38862: svn-apply: Eliminate the "copiedFiles" hash
https://bugs.webkit.org/show_bug.cgi?id=38862
Attachment 55638: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=55638&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Do we know this is covered properly with tests?
I woudl have written this:
+ my $exitStatus = exitStatus($?);
+ return $exitStatus == 0;
as just:
return exitStatus($?) == 0;
Then again, That should really use system instead of `` since it doesn't
need/want the output.
More information about the webkit-reviews
mailing list