[webkit-reviews] review granted: [Bug 38526] [Qt] REGRESSION: CoolClock isn't rendered properly : [Attachment 55479] Proposed patch v4
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 10 18:54:55 PDT 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 38526: [Qt] REGRESSION: CoolClock isn't rendered properly
https://bugs.webkit.org/show_bug.cgi?id=38526
Attachment 55479: Proposed patch v4
https://bugs.webkit.org/attachment.cgi?id=55479&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
Great! Seems that you fixed all comments, so r=me.
I wonder about the generated tests; shouldn't they use the html5 doctype
<!DOCTYPE html> instead of <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> [1]
[1] http://ejohn.org/blog/html5-doctype/
More information about the webkit-reviews
mailing list