[webkit-reviews] review granted: [Bug 38841] Ignore invalid values for various CanvasRenderingContext2D properties : [Attachment 55582] Proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 10 18:18:58 PDT 2010


Darin Adler <darin at apple.com> has granted Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 38841: Ignore invalid values for various CanvasRenderingContext2D
properties
https://bugs.webkit.org/show_bug.cgi?id=38841

Attachment 55582: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=55582&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +PASS ctx.miterLimit is 1.5
> +PASS ctx.miterLimit is 1.5
> +PASS ctx.miterLimit is 1.5
> +PASS ctx.miterLimit is 1.5
> +PASS ctx.miterLimit is 1.5
> +PASS ctx.miterLimit is 1.5
> +PASS ctx.lineWidth is 1.5
> +PASS ctx.lineWidth is 1.5
> +PASS ctx.lineWidth is 1.5
> +PASS ctx.lineWidth is 1.5
> +PASS ctx.lineWidth is 1.5
> +PASS ctx.lineWidth is 1.5
> +PASS ctx.shadowOffsetX is 1
> +PASS ctx.shadowOffsetY is 2
> +PASS ctx.shadowOffsetX is 1
> +PASS ctx.shadowOffsetY is 2
> +PASS ctx.shadowOffsetX is 1
> +PASS ctx.shadowOffsetY is 2
> +PASS ctx.shadowBlur is 1
> +PASS ctx.shadowBlur is 1
> +PASS ctx.shadowBlur is 1
> +PASS ctx.shadowBlur is 1
> +PASS successfullyParsed is true

This is the old expected file. You need to regenerate this file.

You should upload a new patch, because if we land this one all the bots will
fail!

Otherwise, r=me


More information about the webkit-reviews mailing list