[webkit-reviews] review granted: [Bug 38873] [V8] Fix V8 code generator script to generate the correct code for converting ScriptString : [Attachment 55613] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 10 15:51:16 PDT 2010


Adam Barth <abarth at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 38873: [V8] Fix V8 code generator script to generate the correct code for
converting ScriptString
https://bugs.webkit.org/show_bug.cgi?id=38873

Attachment 55613: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=55613&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/bindings/scripts/CodeGeneratorV8.pm: 
 +	    return "v8StringOrNull(exec, $value)" if $conv;
Oh, sorry.  I should have caught that in review.  :(


More information about the webkit-reviews mailing list