[webkit-reviews] review granted: [Bug 38861] new-run-webkit-tests fails when run under sys.platform == "windows" due to undefined signal.SIGKILL : [Attachment 55591] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 10 12:43:10 PDT 2010


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 38861: new-run-webkit-tests fails when run under sys.platform == "windows"
due to undefined signal.SIGKILL
https://bugs.webkit.org/show_bug.cgi?id=38861

Attachment 55591: Patch
https://bugs.webkit.org/attachment.cgi?id=55591&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok, but you need to make these comments compile.  :)

WebKitTools/Scripts/webkitpy/common/system/executive_unittest.py:79
 +	    # Note: Can't use a ternary since signal.SIGKILL is undefined for
platform.sys == "windows"
What is platform.sys ?


More information about the webkit-reviews mailing list