[webkit-reviews] review granted: [Bug 38689] #34005 will break fullscreen video playback : [Attachment 55565] Redefinition of PlatformMedia
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 10 11:25:29 PDT 2010
Sam Weinig <sam at webkit.org> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 38689: #34005 will break fullscreen video playback
https://bugs.webkit.org/show_bug.cgi?id=38689
Attachment 55565: Redefinition of PlatformMedia
https://bugs.webkit.org/attachment.cgi?id=55565&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
> void FullscreenVideoController::setMediaElement(HTMLMediaElement*
mediaElement)
WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:606
+ platformMedia.media.qtMovie = m_qtMovie;
Some thing odd here.
WebKit/win/FullscreenVideoController.cpp:204
+ return platformMedia.media.qtMovieGWorld;
Spacing again.
r=me with those changes.
More information about the webkit-reviews
mailing list