[webkit-reviews] review granted: [Bug 37712] Refactor WebGLArray types to share more code : [Attachment 55562] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 10 10:34:48 PDT 2010


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 37712: Refactor WebGLArray types to share more code
https://bugs.webkit.org/show_bug.cgi?id=37712

Attachment 55562: Patch
https://bugs.webkit.org/attachment.cgi?id=55562&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
WebCore/ChangeLog:80
 +  
It would be great to either annotate each change or just remove this huge
laundry list of files from the ChangeLog -- you already have refactoring
described.

WebCore/html/canvas/WebGLTypedArrayBase.h:85
 +	    return adoptRef(new Subclass(buf, byteOffset, length));
Awesome.


More information about the webkit-reviews mailing list