[webkit-reviews] review denied: [Bug 31018] Accessibility: Implement isSelected in DRT for GTK : [Attachment 55526] Patch to fix this bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 10 10:08:41 PDT 2010


Xan Lopez <xan.lopez at gmail.com> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 31018: Accessibility: Implement isSelected in DRT for GTK
https://bugs.webkit.org/show_bug.cgi?id=31018

Attachment 55526: Patch to fix this bug
https://bugs.webkit.org/attachment.cgi?id=55526&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
re GRefPtr, it does not really matter that you are not adding the ref yourself,
what GRefPtr does is get rid of the reference when the object goes out of
scope. You'd use it like:

GRefPtr<AtkStateSet> stateSet = atk_object_ref_state_set() ...

and then you can get rid of the g_object_unref.

I think it makes sense to use it, so r- because of that. Also, you can probably
add the bug URL and title to the ChangeLog in the layout tests.


More information about the webkit-reviews mailing list