[webkit-reviews] review requested: [Bug 37712] Refactor WebGLArray types to share more code : [Attachment 55562] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 10 09:48:43 PDT 2010


Kenneth Russell <kbr at google.com> has asked  for review:
Bug 37712: Refactor WebGLArray types to share more code
https://bugs.webkit.org/show_bug.cgi?id=37712

Attachment 55562: Patch
https://bugs.webkit.org/attachment.cgi?id=55562&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
>From the ChangeLog:

Refactored WebGLArray types for maximal code sharing. Added WebGLTypedArrayBase
and WebGLIntegralTypedArrayBase template superclasses. Changed overridden
virtuals to have minimal visibility (private instead of public). Fixed const
correctness of a few methods. There are no changes to the public APIs of the
WebGLArray classes; the JavaScript bindings are unchanged.

No new tests; existing tests cover this functionality. Ran all WebGL layout
tests in Safari and Chromium on Mac OS X.


More information about the webkit-reviews mailing list