[webkit-reviews] review requested: [Bug 38630] VS2010 asserts a null iterator passed to std::copy in Vector::operator= : [Attachment 55543] Kent's proposal patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 10 04:53:35 PDT 2010
Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has asked for review:
Bug 38630: VS2010 asserts a null iterator passed to std::copy in
Vector::operator=
https://bugs.webkit.org/show_bug.cgi?id=38630
Attachment 55543: Kent's proposal patch
https://bugs.webkit.org/attachment.cgi?id=55543&action=review
------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
Here is a patch for the proposed fix.
This adds a branch when other.size() is non-zero and fits in capacity(), but
exit earlier in other cases.
I would also be ok with wrapping the previous patch in a MSVC/MSVC2010 specific
macro piece if you think this one has issues.
Anyhow the msvc behavior, being a bug or not, has been reported there:
https://connect.microsoft.com/VisualStudio/feedback/details/558044/std-copy-sho
uld-not-check-dest-when-first-last
More information about the webkit-reviews
mailing list