[webkit-reviews] review granted: [Bug 38750] [Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace() : [Attachment 55531] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted hans at chromium.org's request for
review:
Bug 38750: [Chromium] Add quota parameter to
WebViewClient::createSessionStorageNamespace()
https://bugs.webkit.org/show_bug.cgi?id=38750

Attachment 55531: Patch
https://bugs.webkit.org/attachment.cgi?id=55531&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
> diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
> index
8a25606961ee8b3995a77c5a97e7bedcb9135890..5d13f4d8b182fd1ae743f5c3c0548e1414c47
a4a 100644
> --- a/WebKit/chromium/ChangeLog
> +++ b/WebKit/chromium/ChangeLog
> @@ -1,3 +1,21 @@
> +2010-05-10  Hans Wennborg  <hans at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [Chromium] Add quota parameter to
WebViewClient::createSessionStorageNamespace()
> +
> +	   Put a per-origin quota on session storage since it is using memory
in
> +	   the browser process, and should not be allowed to grow arbitrarily
> +	   large. See also r58828.

Links to trac.webkit.org are probably better than just saying rXXXXX.

> +	   https://bugs.webkit.org/show_bug.cgi?id=38750

This goes directly below the subject line...then a blank newline...then the
full description.


Same goes for the other change log.

Otherwise, looks good.	Please fix and re-upload with commit queue bit since
you can't commit yet.