[webkit-reviews] review granted: [Bug 37046] Create a class that can be extended to prevent objects from being placed on the heap : [Attachment 52464] patch (v6)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 9 14:39:35 PDT 2010
Eric Seidel <eric at webkit.org> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 37046: Create a class that can be extended to prevent objects from being
placed on the heap
https://bugs.webkit.org/show_bug.cgi?id=37046
Attachment 52464: patch (v6)
https://bugs.webkit.org/attachment.cgi?id=52464&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Patch looks good to me. Mark is right about the indent though, meaning we
can't cq this as-is. You can use webkit-patch land-safely once you've modified
locally to have it automatically fill in the reviewer and upload a patch for
the commit-queue (if you're a committer). If you're not a committer, you'll
have to just post it for review/commit again or get someone to land it for you.
More information about the webkit-reviews
mailing list