[webkit-reviews] review granted: [Bug 38683] SVG FilterEffects need more detailed DRT information : [Attachment 55501] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 38683: SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683

Attachment 55501: Patch
https://bugs.webkit.org/attachment.cgi?id=55501&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Seems OK.

I worry a little about having so much serialization code that is only for
DumpRenderTree. I wish there was a way to repurpose something that's actually
useful directly in production environments.

I also think that "external representation" is a strange name for a function
that writes to a stream. I'd name it with a verb instead of a noun.