[webkit-reviews] review denied: [Bug 37633] Spatial Navigation: use a static var in maxDistance method ( SpatialNavigation.h ) : [Attachment 53403] patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 9 14:01:00 PDT 2010
Eric Seidel <eric at webkit.org> has denied Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>'s request for review:
Bug 37633: Spatial Navigation: use a static var in maxDistance method (
SpatialNavigation.h )
https://bugs.webkit.org/show_bug.cgi?id=37633
Attachment 53403: patch v1
https://bugs.webkit.org/attachment.cgi?id=53403&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems like this makes no sense as an inline if you're doing this.
Why do we want this? Is this a performance win? numeric_limits<long
long>::max() should already be a static lookup, no?
More information about the webkit-reviews
mailing list