[webkit-reviews] review granted: [Bug 34994] Add sync bindings for Worker access to DB : [Attachment 55472] patch #4: V8 bindings implementation

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 34994: Add sync bindings for Worker access to DB
https://bugs.webkit.org/show_bug.cgi?id=34994

Attachment 55472: patch #4: V8 bindings implementation
https://bugs.webkit.org/attachment.cgi?id=55472&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Thanks!  Please consider the comment below before landing.  Again, assuming
bradee-oh isn't interested in reviewing V8 bindings.

WebCore/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:66
 +	    EXCEPTION_BLOCK(v8::Local<v8::Value>, length,
sqlArgsObject->Get(v8::String::New("length")));
This code looks very similar to the code for the async case.  Can we call some
common routine instead of copy/pasting the code?