[webkit-reviews] review granted: [Bug 38047] svn-apply: suppress misleading "error: pathspec ..." message when adding binary file : [Attachment 55477] Proposed patch 3

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 38047: svn-apply: suppress misleading "error: pathspec ..." message when
adding binary file
https://bugs.webkit.org/show_bug.cgi?id=38047

Attachment 55477: Proposed patch 3
https://bugs.webkit.org/attachment.cgi?id=55477&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
We should add a comment to reference the Perldocs about this.

> +sub callSilently($@) {
> +    my ($func, @args) = @_;
> +
> +    open(OLDERR, ">&STDERR");
> +    close(STDERR);
> +    my @returnValue = &$func(@args);
> +    open(STDERR, ">&OLDERR");
> +    close(OLDERR); # FIXME: Is this necessary?
> +
> +    return @returnValue;
> +}
> +

We should probably change this to use exitStatus. We can do this in another
patch, but then we should add a FIXME comment.

> +sub gitKnowsOfFile($)
> +{
> +    my $path = shift;
> +
> +    `git ls-files --error-unmatch -- $path`;
> +    my $exitCode = $? >> 8;
> +    return $exitCode == 0;
> +}

r=me.