[webkit-reviews] review denied: [Bug 37515] getPathSegAtLength() gives incorrect value : [Attachment 55468] 3rd patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 8 00:53:20 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has denied Robin Qiu
<robin.qiu at torchmobile.com.cn>'s request for review:
Bug 37515: getPathSegAtLength() gives incorrect value
https://bugs.webkit.org/show_bug.cgi?id=37515

Attachment 55468: 3rd patch
https://bugs.webkit.org/attachment.cgi?id=55468&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
WebCore/svg/SVGPathSegList.cpp:103
 +	return --traversalState.m_segmentIndex;
Hm, why is that? Just return "traversalState.m_segmentIndex - 1". That saves
one assignment operation :-)
Sorry for that, but r- :( Other than that it looks very good, If you change
that last thing, I'm going to set r+/cq+


More information about the webkit-reviews mailing list