[webkit-reviews] review granted: [Bug 38718] test-webkitpy fails under cygwin : [Attachment 55459] Fix comment for Dirk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 7 23:00:13 PDT 2010


Daniel Bates <dbates at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 38718: test-webkitpy fails under cygwin
https://bugs.webkit.org/show_bug.cgi?id=38718

Attachment 55459: Fix comment for Dirk
https://bugs.webkit.org/attachment.cgi?id=55459&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
> +    # Executive unit tests uses this information to validate that
> +    # kill_process/kill_all work as expected an cause the expected exit
codes.

Typo, "an" should be "and".

> +    # FIXME: This list may be incomplete as Apple has some sekret configs.

Looks like you intentionally misspelled "sekret" :-P.

Looks good to me.


More information about the webkit-reviews mailing list