[webkit-reviews] review denied: [Bug 37515] getPathSegAtLength() gives incorrect value : [Attachment 55452] Forgot to set "review ?". Modified according to Niko's comment.

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Robin Qiu
<robin.qiu at torchmobile.com.cn>'s request for review:
Bug 37515: getPathSegAtLength() gives incorrect value
https://bugs.webkit.org/show_bug.cgi?id=37515

Attachment 55452: Forgot to set "review ?".  Modified according to Niko's
comment.
https://bugs.webkit.org/attachment.cgi?id=55452&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
WebCore/svg/SVGPathSegList.cpp:96
 +	    if (!segmentLength)
Almost r+, the test is perfect. Just this line bugs me, from a SVG DOM
perspective, "M 5 5" and "M 5 5 M 5 5" are two different path segments, no
matter how it's rendered.
Also how can you be sure this is just a "move"? And why is the first move the
one ignored? I guess this is not correct.