[webkit-reviews] review granted: [Bug 38692] rebaseline-chromium-webkit-tests crashes if nothing is built : [Attachment 55449] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 38692: rebaseline-chromium-webkit-tests crashes if nothing is built
https://bugs.webkit.org/show_bug.cgi?id=38692

Attachment 55449: Patch
https://bugs.webkit.org/attachment.cgi?id=55449&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I dislike the way we do the testing for the existance of the image_diff binary.
 However, you've not changed the previous code, and it's now tested, so this
patch is a huge win! :)

I think that the design error here is that configuration is a property of a
port.  It's information provided to a port, but it is not itself a property of
said port.  Since it is, it makes use create a port just to test a
configuration.	Waht we really want to do is have some port instance which we
can then ask questions pertaining to a configuration, and then store that
configuration either in the port or separate.

Thanks for all the hard work!