[webkit-reviews] review requested: [Bug 38784] need new chromium win baselines for bugfix for chromium bug 43319 : [Attachment 55441] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 7 17:39:40 PDT 2010


Dirk Pranke <dpranke at chromium.org> has asked  for review:
Bug 38784: need new chromium win baselines for bugfix for chromium bug 43319
https://bugs.webkit.org/show_bug.cgi?id=38784

Attachment 55441: patch
https://bugs.webkit.org/attachment.cgi?id=55441&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
baselines added. The rebaseline tool was working correctly most likely when
Jeremy was trying to get the windows baselines. The problem is, that it would
pull from the XP bots and try to put the files in chromium win, which would
only pass on a Win XP machine (and is wrong, to boot).

The rebaseline tool isn't smart enough to handle version-specific baselines
(although it can pull into the right directories if you tell it to).


More information about the webkit-reviews mailing list