[webkit-reviews] review granted: [Bug 38644] Optimize access to the global object from a function that uses eval : [Attachment 55432] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 38644: Optimize access to the global object from a function that uses eval
https://bugs.webkit.org/show_bug.cgi?id=38644

Attachment 55432: Patch
https://bugs.webkit.org/attachment.cgi?id=55432&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I think you can share emit_op_resolve_global_dynamic.

+    requiresDynamicChecks = d()->functionExecutable->usesEval();

Maybe this should be |=, to avoid stomping other functions' results.

"requiresDynamicChecks" sounds a bit too much like "isDynamicScope" to me. How
about "mayBecomeDynamicScope"?

r=me