[webkit-reviews] review requested: [Bug 38213] Page up / page down moves edited content for the entire height : [Attachment 55433] Addressed the latest set of comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 7 16:50:05 PDT 2010


Zelidrag Hornung <zelidrag at chromium.org> has asked  for review:
Bug 38213: Page up / page down moves edited content for the entire height
https://bugs.webkit.org/show_bug.cgi?id=38213

Attachment 55433: Addressed the latest set of comments
https://bugs.webkit.org/attachment.cgi?id=55433&action=review

------- Additional Comments from Zelidrag Hornung <zelidrag at chromium.org>
Please note that test scroll-viewport-page-up-down.html covers platform
differences in scroll view between mac and other platforms while
option-page-up-down.html actually ensures that the cursor it on the same line
on page up/down event regardless of the platform. 

* (re)added somehow dropped per-function comments into ChangeLog
* renames SelectionController::CursorAlignOnScroll enum and its values to give
more details about what they do
* removed #include "RenderBox.h" from WebCore/editing/EditorCommand.cpp
* renames cursorAlignment param
* changed #if OS(DARWIN) to settings->editingBehavior() == EditingMacBehavior
in SelectionController.cpp


More information about the webkit-reviews mailing list