[webkit-reviews] review denied: [Bug 38685] [Qt] tst_QWebPage::inputMethods failing on Maemo5 : [Attachment 55423] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 38685: [Qt] tst_QWebPage::inputMethods failing on Maemo5
https://bugs.webkit.org/show_bug.cgi?id=38685

Attachment 55423: Patch
https://bugs.webkit.org/attachment.cgi?id=55423&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
So this part of the test checks that the SIP is triggered not on the first
mouse click but on the _second_, corresponding to
style->styleHint(...::RequestSoftwareInputPanel) != RSIP_OnMouseClick.

See QWebPagePrivate::handleSoftwareInputPanel

So the auto-test should probably adjust its expected result - either RSIP on
first or second click - depending on the return value of the styleHint()
function on the current style.

Then the auto-test could be written without platform #ifdefs :)