[webkit-reviews] review denied: [Bug 38685] [Qt] tst_QWebPage::inputMethods failing on Maemo5 : [Attachment 55422] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 7 15:17:26 PDT 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 38685: [Qt] tst_QWebPage::inputMethods failing on Maemo5
https://bugs.webkit.org/show_bug.cgi?id=38685
Attachment 55422: Patch
https://bugs.webkit.org/attachment.cgi?id=55422&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1368
+ #ifndef Q_WS_MAEMO_5
It would really be good with a comment here why there are different results, r-
because of that. That should ALSO be in the ChangeLog.
More information about the webkit-reviews
mailing list