[webkit-reviews] review denied: [Bug 38704] SVG pattern size changed when resizing browser : [Attachment 55345] Patch (without optimization)

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Steven Lai <s3lance at hotmail.com>'s
request for review:
Bug 38704: SVG pattern size changed when resizing browser
https://bugs.webkit.org/show_bug.cgi?id=38704

Attachment 55345: Patch (without optimization)
https://bugs.webkit.org/attachment.cgi?id=55345&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
We should realy think about clipping here. I maybe mixed up this bug with
another clipping bug we had with pattern. On the other bug, we also clipped the
content of the pattern to viewPort, and that had the problems with determing
the correct drawing are on skewing.
Maybe this is not quite relevant here. We know the strokeBoundaries of the
target-element, and the tmpImageBuffer for the pattern don't need to be bigger
(after all transformations) than the strokeBoundaries of the target.
We need some test cases, but maybe Niko is right and we don't care about the
type of transformation, but just about the resulting size of the pattern.
And this is quite easy to check. We can transform the current boundaries of the
Pattern with the transfromation matrix of the pattern and clip it to the
strokeBoundaries of the target.