[webkit-reviews] review canceled: [Bug 38488] Spatial Navigation: create a getter for the "fudgeFactor" : [Attachment 54961] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 7 12:49:40 PDT 2010


Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has canceled Antonio Gomes
(tonikitoo) <tonikitoo at webkit.org>'s request for review:
Bug 38488: Spatial Navigation: create a getter for the "fudgeFactor"
https://bugs.webkit.org/show_bug.cgi?id=38488

Attachment 54961: patch v1
https://bugs.webkit.org/attachment.cgi?id=54961&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>

> I would prefer you using a positive fudgeFactor (btw that is not really a
> factor, but a constant) and add the minuses in the code itself. You could
even
> make fudgeFactor return a unsigned int.

done


More information about the webkit-reviews mailing list