[webkit-reviews] review denied: [Bug 38526] [Qt] REGRESSION: CoolClock isn't rendered properly : [Attachment 55402] Proposed patch v3 + 2 tests

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 38526: [Qt] REGRESSION: CoolClock isn't rendered properly
https://bugs.webkit.org/show_bug.cgi?id=38526

Attachment 55402: Proposed patch v3 + 2 tests
https://bugs.webkit.org/attachment.cgi?id=55402&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
r-, but almost there.

if you add fast/canvas/script-tests/foo.js, the fast/canvas/foo.html must
exist. Your names don't match.
The problem is that you've manually generated the foo.html files, instead of
using make-js-test-wrappers.
You should never modify them by hand, but instead create the <canvas> file
automatically. See the other existing tests.
Whenever someone would run make-js-test-wrappers, it would regenerate/overwrite
your changes.

Hope you see the issue?