[webkit-reviews] review denied: [Bug 38749] [Chromium] Pipe RTL info into WebPopupMenuInfo : [Attachment 55374] A patch to fill in a "right aligned" attr in the menu info

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Avi Drissman
<avi at drissman.com>'s request for review:
Bug 38749: [Chromium] Pipe RTL info into WebPopupMenuInfo
https://bugs.webkit.org/show_bug.cgi?id=38749

Attachment 55374: A patch to fill in a "right aligned" attr in the menu info
https://bugs.webkit.org/attachment.cgi?id=55374&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebPopupMenuInfo.h:47
 +	bool rightAligned;
Use the WebTextDirection enum here?

WebKit/chromium/src/ChromeClientImpl.cpp:694
 +	info->rightAligned = popupClient->menuStyle().textDirection() == RTL;
Why not just get the PopupMenuStyle object from the PopupContainer?
You could add a method on PopupContainer that returns PopupMenuStyle*.
It doesn't seem necessary to plumb PopupMenuClient* through the layers
when you have PopupContainer at your disposal.