[webkit-reviews] review granted: [Bug 38438] [Qt] Platform plugin : [Attachment 54903] patch 2

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Luiz Agostini
<luiz.agostini at openbossa.org>'s request for review:
Bug 38438: [Qt] Platform plugin
https://bugs.webkit.org/show_bug.cgi?id=38438

Attachment 54903: patch 2
https://bugs.webkit.org/attachment.cgi?id=54903&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
WebKit/qt/Api/qwebkitplatformplugin.h:34
 +	~QWebSelectData() {}
Please add the inline keyword before landing.

WebKit/qt/Api/qwebkitplatformplugin.h:51
 +	~QWebSelectMethod() {}
Ditto :)

I think the patch looks good otherwise. My only other concern would be that
this slows down the startup time. I think it would be better if the plugin was
loaded on-demand. That can be done in a follow-up patch.