[webkit-reviews] review denied: [Bug 38753] Web Inspector: Autocompletion in console is not usable because it is not add to the entered text the common prefix of suggestions. : [Attachment 55378] [patch] Initial version.

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 38753: Web Inspector: Autocompletion in console is not usable because it is
not add to the entered text the common prefix of suggestions.
https://bugs.webkit.org/show_bug.cgi?id=38753

Attachment 55378: [patch] Initial version.
https://bugs.webkit.org/attachment.cgi?id=55378&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
WebCore/inspector/front-end/TextPrompt.js:234
 +			for (var j = wordPrefixLength; j < lastIndex; ++j)
Need {} around the body, since it is multiline (per style guide.)

WebCore/inspector/front-end/TextPrompt.js:248
 +			for (var i = 0; i < completions.length; ++i)
Need {} around the body, since it is multiline (per style guide.)


WebCore/inspector/front-end/TextPrompt.js:235
 +			    if (commonPrefix[j] != completion[j]) {
!==

WebCore/inspector/front-end/TextPrompt.js:236
 +				commonPrefix = commonPrefix.substr(0,j);
Add a space after ",".

Otherwise looks great! Thanks for the screencast.