[webkit-reviews] review denied: [Bug 26224] [Qt, Gtk] Allows build-webkit script to receive an install prefix as parameter : [Attachment 55152] Patch with --prefix for gtk and --install-headers and --install-libs for qt

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Rodrigo Belem
<rclbelem at gmail.com>'s request for review:
Bug 26224: [Qt, Gtk] Allows build-webkit script to receive an install prefix as
parameter
https://bugs.webkit.org/show_bug.cgi?id=26224

Attachment 55152: Patch with --prefix for gtk and --install-headers and
--install-libs for qt
https://bugs.webkit.org/attachment.cgi?id=55152&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

>      !symbian {
>	   headers.files = $$WEBKIT_INSTALL_HEADERS
> -	   headers.path = $$[QT_INSTALL_HEADERS]/QtWebKit
> -	   target.path = $$[QT_INSTALL_LIBS]
> +	   isEmpty(INSTALL_HEADERS) {
> +	       headers.path = $$[QT_INSTALL_HEADERS]/QtWebKit
> +	   } else {
> +	       headers.path = $$INSTALL_HEADERS/QtWebKit
> +	   }
> +
> +	   isEmpty(INSTALL_LIBS) {
> +	       target.path = $$[QT_INSTALL_LIBS]
> +	   } else {
> +	       target.path = $$INSTALL_LIBS
> +	   }

This needs to be done also for the Symbian path. Maybe it's easiest to do
it like this:

isEmpty(INSTALL_HEADERS): INSTALL_HEADERS = $$[QT_INSTALL_HEADERS]

and then later use that variable in both blocks.

The rest of the patch looks good to me, so r- only because of the missing
Symbian block.