[webkit-reviews] review granted: [Bug 34005] Safari pegs CPU and drops tons of frames using HTML5 Vimeo player : [Attachment 55056] Part 4.2: WebCore: New class MediaPlayerPrivateQuickTimeVisualContext, the modification

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 34005: Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
https://bugs.webkit.org/show_bug.cgi?id=34005

Attachment 55056: Part 4.2: WebCore: New class
MediaPlayerPrivateQuickTimeVisualContext, the modification
https://bugs.webkit.org/attachment.cgi?id=55056&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>

> +void MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage()
> +{
> +    if (!m_visualContext)
> +	   return;
> +
> +    if (!m_qtVideoLayer)
> +	   return;
> +
> +    QTPixelBuffer buffer = m_visualContext->imageForTime(0);
> +    if (!buffer.pixelBufferRef())
> +	   return;
> +
I assume imageForTime(0) gets the image for "now"? I realize that it just 
wraps QTVisualContextCopyImageForTime and that functions defines the magic
value, but it would be nice
to define a constant instead of passing "0" - "kCurrentMovieTime" maybe ?


> +
> +	   CFTimeInterval imageTime = QTMovieVisualContext::currentHostTime();
> +
"imageTime" isn't used anywhere, left over from earlier revision?

r=me