[webkit-reviews] review granted: [Bug 38687] Improve code generator scripts to pass additional ScriptExecutionContext argument to the constructor : [Attachment 55309] Proposed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 6 15:52:19 PDT 2010
Adam Barth <abarth at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 38687: Improve code generator scripts to pass additional
ScriptExecutionContext argument to the constructor
https://bugs.webkit.org/show_bug.cgi?id=38687
Attachment 55309: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=55309&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Thanks. Please add a test to run-bindings-tests before landing through.
WebCore/bindings/v8/V8Proxy.h:412
+ return throwError(V8Proxy::TypeError, "");
We should add version of throwError that doesn't need a string. We basically
never want to provide a string.
More information about the webkit-reviews
mailing list