[webkit-reviews] review denied: [Bug 38692] rebaseline-chromium-webkit-tests crashes if nothing is built : [Attachment 55298] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 6 15:17:52 PDT 2010
Eric Seidel <eric at webkit.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 38692: rebaseline-chromium-webkit-tests crashes if nothing is built
https://bugs.webkit.org/show_bug.cgi?id=38692
Attachment 55298: Patch
https://bugs.webkit.org/attachment.cgi?id=55298&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
I dislike this fallback logic. I think we should respect
set-webkit-configuration and then possibly have auto-fallback from whatever
that is defaulted to. No other script has this strange fallback stuff.
That said, this change didn't make it any worse.
This change however lacks any unit testing. It should be simple to test this.
More information about the webkit-reviews
mailing list