[webkit-reviews] review granted: [Bug 38594] Change IndexedDB to use events instead of callbacks : [Attachment 55258] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 38594: Change IndexedDB to use events instead of callbacks
https://bugs.webkit.org/show_bug.cgi?id=38594

Attachment 55258: Patch
https://bugs.webkit.org/attachment.cgi?id=55258&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
Your WebCore/ChangeLog diff is pretty far out of date in terms of the files
listed. Plus a couple of nits inline.

Besides that, LGTM.

> --- a/WebCore/bindings/js/JSEventCustom.cpp
> +++ b/WebCore/bindings/js/JSEventCustom.cpp
> @@ -38,6 +38,7 @@
>  #include "JSCustomEvent.h"
>  #include "JSCompositionEvent.h"
>  #include "JSErrorEvent.h"
> +#include "JSIDBRequest.h"
>  #include "JSKeyboardEvent.h"
>  #include "JSMessageEvent.h"
>  #include "JSMouseEvent.h"

Why is this necessary?

> +    ASSERT(0);
> +    return jsUndefined();
> +}

Nit (here and in V8IDBRequestCustom.cpp): Any reason not to use
ASSERT_NOT_REACHED instead?