[webkit-reviews] review denied: [Bug 38687] Improve code generator scripts to pass additional ScriptExecutionContext argument to the constructor and convert ScriptString : [Attachment 55293] Proposed Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Jian Li <jianli at chromium.org>'s
request for review:
Bug 38687: Improve code generator scripts to pass additional
ScriptExecutionContext argument to the constructor and convert ScriptString
https://bugs.webkit.org/show_bug.cgi?id=38687

Attachment 55293: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=55293&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This is really two patches.  Can you split it in two?  Also, please add test
coverage in TestObj.idl.  Other than that, these patches look good.

WebCore/bindings/scripts/CodeGeneratorJS.pm:1120
 +	    push(@implContent, constructorFor($className, $protoClassName,
$interfaceName, $visibleClassName,
$dataNode->extendedAttributes->{"CanBeConstructed"},
$dataNode->extendedAttributes->{"CallWith"}));
I wonder if would be better to pass $dataNode here.

WebCore/bindings/v8/V8Proxy.h:412
 +		return throwError(V8Proxy::TypeError, "DOM object constructor
cannot be called as a function.");
Please remove these non-localized strings.  The JSC bindings don't have them
and we should aim to be identical.

WebCore/bindings/v8/V8Proxy.h:416
 +		return throwError(V8Proxy::ReferenceError, "DOM object
constructor's associated frame is not available");
Please remove these non-localized strings.  The JSC bindings don't have them
and we should aim to be identical.

WebCore/bindings/v8/V8Proxy.h:422
 +	    obj->ref();
Manual reference twiddling is sadness.