[webkit-reviews] review denied: [Bug 38633] [WTFURL] Add Chromium front-end to the URL parser : [Attachment 55218] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 6 13:41:29 PDT 2010


Adam Barth <abarth at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 38633: [WTFURL] Add Chromium front-end to the URL parser
https://bugs.webkit.org/show_bug.cgi?id=38633

Attachment 55218: Patch
https://bugs.webkit.org/attachment.cgi?id=55218&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I spoke to fishd on the phone.	We're going to do this in two layers:

1) A stable opaque interface in WebKit style in svn.webkit.org.
2) A re-syndication of that interface in Chromium style in svn.chromium.org.

By using inline functions, there shouldn't be any runtime impact of using two
layers.  There's just a bit of complexity, but we get a clear definition of the
dependencies in return.


More information about the webkit-reviews mailing list