[webkit-reviews] review denied: [Bug 38640] [Chromium] Suggestion popup is not closed when view is scrolled : [Attachment 55231] patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Roman
<romange at google.com>'s request for review:
Bug 38640: [Chromium] Suggestion popup is not closed when view is scrolled
https://bugs.webkit.org/show_bug.cgi?id=38640

Attachment 55231: patch
https://bugs.webkit.org/attachment.cgi?id=55231&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: src/ChromeClientImpl.cpp
> ===================================================================
> --- src/ChromeClientImpl.cpp	(revision 58877)
> +++ src/ChromeClientImpl.cpp	(working copy)
> @@ -507,6 +507,7 @@ void ChromeClientImpl::scroll(

scroll is only called when we are doing accelerated scrolling.	if the
page contains a fixed position element, then invalidateRect will be used
to repaint the entire view.  so, this patch only solves part of the problem.

i think you should really hook into the same thing that triggers the
'scroll' event being dispatched to the page.