[webkit-reviews] review denied: [Bug 38508] [chromium] WebViewClient should have a notification when a new node gets the focus : [Attachment 54998] Adding a notification on WebViewClient for focus change events.

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jay Civelli
<jcivelli at chromium.org>'s request for review:
Bug 38508: [chromium] WebViewClient should have a notification when a new node
gets the focus
https://bugs.webkit.org/show_bug.cgi?id=38508

Attachment 54998: Adding a notification on WebViewClient for focus change
events.
https://bugs.webkit.org/attachment.cgi?id=54998&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebViewClient.h:106
 +	virtual void focusNodeChanged(const WebNode&) { }
How about moving this down near the other focus related methods?
(In the UI section.)

WebKit/chromium/src/ChromeClientImpl.cpp:218
 +	m_webView->client()->focusNodeChanged(WebNode(node));
focusedNodeChanged seems like a better name for this method.