[webkit-reviews] review granted: [Bug 37874] Provide mechanism to cache metadata for a resource : [Attachment 55255] Make CachedMetadata own data and reference count it

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 37874: Provide mechanism to cache metadata for a resource
https://bugs.webkit.org/show_bug.cgi?id=37874

Attachment 55255: Make CachedMetadata own data and reference count it
https://bugs.webkit.org/attachment.cgi?id=55255&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Looks good.  Thanks for iterating on this patch.  Please address the minor nits
below before committing.  If you'd like the commit bot to land your patch, you
can upload a new patch with these comments addressed.

WebCore/loader/CachedMetadata.h:66
 +	    return new CachedMetadata(dataTypeID, data, size);
adoptRef?

WebCore/loader/CachedMetadata.h:71
 +	    return new CachedMetadata(data, size);
adoptRef?

WebCore/loader/CachedMetadata.h:62
 +	friend class CachedResource;
You can just make these methods public.  WebKit isn't super tight about hiding
interfaces.

WebCore/loader/ResourceLoader.h:101
 +	    virtual void didReceiveCachedMetadata(ResourceHandle*, const char*
data, int length) { didReceiveCachedMetadata(data, length); }
These methods don't seem to fit the pattern of the other methods.