[webkit-reviews] review granted: [Bug 38651] WebFrame::paintDocumentRectToContext paints content at the wrong location : [Attachment 55252] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 38651: WebFrame::paintDocumentRectToContext paints content at the wrong
location
https://bugs.webkit.org/show_bug.cgi?id=38651

Attachment 55252: Patch
https://bugs.webkit.org/attachment.cgi?id=55252&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> @@ -348,11 +348,8 @@ HRESULT STDMETHODCALLTYPE WebFrame::pain
>      gc.save();
>      LONG width = rect.right - rect.left;
>      LONG height = rect.bottom - rect.top;
> -    FloatRect dirtyRect;
> -    dirtyRect.setWidth(width);
> -    dirtyRect.setHeight(height);
> +    FloatRect dirtyRect(rect.left, rect.top, width, height);

You could get rid of the width and height variables by doing:

FloatRect dirtyRect(IntRect(rect));

Too bad we don't have a way to test this.

r=me