[webkit-reviews] review denied: [Bug 38631] Chromium Dev Tools: Large toolbar icons flash when dev tools is opened in docked mode. : [Attachment 55214] [PATCH] Proposed change.

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 38631: Chromium Dev Tools: Large toolbar icons flash when dev tools is
opened in docked mode.
https://bugs.webkit.org/show_bug.cgi?id=38631

Attachment 55214: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=55214&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
WebKit/chromium/src/js/DevTools.js:195
 +	var paramsIndex = window.location.href.indexOf("?");
Use window.location.search, and it will be just the query string part (plus the
prefix "?".)

WebKit/chromium/src/js/DevTools.js:200
 +		var pair = params[i].split("=");
Do you need to worry about URL encoding? If so you should call
decodeURIComponent.

WebKit/chromium/src/js/DevTools.js:202
 +	    }
I like extra lines after these.

WebKit/chromium/src/js/DevTools.js:207
 +  }
Ditto.

Use window.location.search, otherwise r+.