[webkit-reviews] review granted: [Bug 37803] Spatial Navigation: adapt the logic of {deep}findFocusableNodeInDirection to do traversal starting from Node* not Document* : [Attachment 54057] patch v3

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Antonio Gomes
(tonikitoo) <tonikitoo at webkit.org>'s request for review:
Bug 37803: Spatial Navigation: adapt the logic of
{deep}findFocusableNodeInDirection to do traversal starting from Node* not
Document*
https://bugs.webkit.org/show_bug.cgi?id=37803

Attachment 54057: patch v3
https://bugs.webkit.org/attachment.cgi?id=54057&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

> 
WebCore/page/FocusController.cpp:393
 +  void FocusController::findFocusableNodeInDirection(Node* outter, Node*
focusedNode,
outer

WebCore/page/FocusController.cpp:398
 +	ASSERT(outter);
outer

WebCore/page/FocusController.cpp:404
 +	Node* candidate = outter;
same thing

WebCore/page/FocusController.cpp:443
 +	// Track if focusedNode is a descendant or not of the current container
node being processed.
no need to add the "or not"