[webkit-reviews] review granted: [Bug 30623] [GTK] Enable DOM clipboard and drag-and-drop access : [Attachment 55131] Slimmed down version of my previous patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 6 05:27:58 PDT 2010


Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 30623: [GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Attachment 55131: Slimmed down version of my previous patch
https://bugs.webkit.org/attachment.cgi?id=55131&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
WebKit/gtk/webkit/webkitprivate.h:155
 +	    HashMap<GdkDragContext*, RefPtr<WebCore::DataObjectGtk> >
draggingDataObjects;
That space between the two >'s looks unintended? =D

WebKit/gtk/WebCoreSupport/DragClientGtk.cpp:87
 +	WEBKIT_WEB_VIEW_GET_PRIVATE(webView)->draggingDataObjects.set(context,
dataObject);
I would prefer having webView->priv be used here, or a private function in
WebKitWebView to do this instead of using GET_PRIVATE, because it's infamous
for not being very efficient heh.


More information about the webkit-reviews mailing list