[webkit-reviews] review denied: [Bug 24289] [Qt] lacks clipToImageBuffer() : [Attachment 55108] porter duff based version again

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 24289: [Qt] lacks clipToImageBuffer()
https://bugs.webkit.org/show_bug.cgi?id=24289

Attachment 55108: porter duff based version again
https://bugs.webkit.org/attachment.cgi?id=55108&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
WebCore/platform/graphics/qt/GraphicsContextQt.cpp:208
 +	QPixmap* alphaMask;
QPixmap is actually a pointer to a QPixmapData object. Storing a QPixmap
pointer is a double indirection, and later in the patch we allocate a QPixmap
on the heap. That's not necessary. I think the code would be simpler and faster
when using a QPixmpap by value here.

WebCore/ChangeLog:11
 +	    inTransparencyLayer() is removed as it is unnecessary.
This is not correct. When building QtWebKit for Windows we compile
WebCore/plugins/PluginViewWin.cpp, which calls this function.

Otherwise this looks good to me. Less pixel manipulation. yay :)