[webkit-reviews] review denied: [Bug 38615] [V8] Add V8 bindings for FileReader interface and turn on FileReader support in Chromium : [Attachment 55184] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 5 23:51:10 PDT 2010


Adam Barth <abarth at webkit.org> has denied Jian Li <jianli at chromium.org>'s
request for review:
Bug 38615: [V8] Add V8 bindings for FileReader interface and turn on FileReader
support in Chromium
https://bugs.webkit.org/show_bug.cgi?id=38615

Attachment 55184: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=55184&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Please try this without custom bindings.  You might need to extend [CallWith]
to work with constructors.

WebCore/bindings/v8/custom/V8FileReaderCustom.cpp:48
 +	    return throwError("DOM object custructor cannot be called as a
function.");
Which spec does this text come from?  Is this text localized?  I don't think we
should have this random custom text in the bindings.


More information about the webkit-reviews mailing list